Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query ipv6 only if specified #1596

Merged
merged 2 commits into from
Jan 30, 2019
Merged

query ipv6 only if specified #1596

merged 2 commits into from
Jan 30, 2019

Conversation

kejxu
Copy link
Contributor

@kejxu kejxu commented Jan 24, 2019

query ipv6 only if rosgraph.network.use_ipv6() returns true; otherwise, scope the query to ipv4 only using socket.AF_INET

@dirk-thomas
Copy link
Member

Thank you for the patch.

@dirk-thomas dirk-thomas merged commit 10674b3 into ros:melodic-devel Jan 30, 2019
@kejxu kejxu deleted the query_ipv6_if_specified branch January 30, 2019 21:00
tahsinkose pushed a commit to tahsinkose/ros_comm that referenced this pull request Apr 15, 2019
* Query resolved_ips according to ipv6()

* Add missing import name (ros#20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants