roscpp: TransportTCP: Allow socket() to return 0 #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In situations that an application has stdin closed, socket() may (and will) return 0. This is totally fine.
|
I would really appreciate if this was also backported to Kinetic.... I will gladly open a PR for the corresponding branch if that's the case. Thank you. |
|
Just to backup the argument up: The same issue can be found in |
Please update the PR to do so. |
|
Done |
|
I am facing the same problem, any updates? |
|
@ros-pull-request-builder retest this please |
|
Thanks for the patch. |
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 4, 2020
* roscpp: TransportTCP: Allow socket() to return 0 In situations that an application has stdin closed, socket() may (and will) return 0. This is totally fine. * TransportUDP: fix incoming socket creation
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 4, 2020
* roscpp: TransportTCP: Allow socket() to return 0 In situations that an application has stdin closed, socket() may (and will) return 0. This is totally fine. * TransportUDP: fix incoming socket creation
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 4, 2020
* roscpp: TransportTCP: Allow socket() to return 0 In situations that an application has stdin closed, socket() may (and will) return 0. This is totally fine. * TransportUDP: fix incoming socket creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations that an application has stdin closed, socket() may (and will) return 0. This is totally fine.