Coverity report potential string overflow in transport_udp.cpp

[danielwangksu]

Using Coverity static analysis tool report a potential string overflow in the following code:

(10) Event fixed_size_dest: You might overrun the 128-character fixed-size string "namebuf" by copying the return value of "inet_ntoa" without checking the length.

ros_comm/clients/roscpp/src/libros/transport/transport_udp.cpp

Line 715 in 29053c4

strcpy(namebuf, inet_ntoa(sin->sin_addr));

(12) Event fixed_size_dest: | You might overrun the 128-character fixed-size string "namebuf" by copying the return value of "inet_ntoa" without checking the length.

ros_comm/clients/roscpp/src/libros/transport/transport_tcp.cpp

Line 744 in 29053c4

strcpy(namebuf, inet_ntoa(sin->sin_addr));

(15) Event fixed_size_dest: | You might overrun the 128-character fixed-size string "namebuf" by copying the return value of "inet_ntoa" without checking the length.

ros_comm/clients/roscpp/src/libros/transport/transport_tcp.cpp

Line 291 in 29053c4

strcpy(namebuf, inet_ntoa(address->sin_addr));

[jspricke]

This just got a public CVE:
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-13566
can we release new versions?

[vmayoral]

Connected to aliasrobotics/RVD#918