Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base64 encode error on ARM #1769

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Fix base64 encode error on ARM #1769

merged 1 commit into from
Aug 8, 2019

Conversation

randoms
Copy link
Contributor

@randoms randoms commented Jul 19, 2019

Fix #1768

@cwecht
Copy link
Contributor

cwecht commented Jul 19, 2019

@ros-pull-request-builder retest this please

@dirk-thomas
Copy link
Member

By default (at least with gcc and MSVC) char is signed. So what is the environment you are trying to build this on? Is it unsigned in your case?

@randoms
Copy link
Contributor Author

randoms commented Aug 8, 2019

I built the code with clang and Android NDK. Here is my full build script and this is my cmake tool chain file.

@dirk-thomas dirk-thomas changed the title Fix base64 encode error Fix base64 encode error on ARM Aug 8, 2019
@dirk-thomas
Copy link
Member

Thanks for the extra context and the patch.

@dirk-thomas dirk-thomas added the bug label Aug 8, 2019
@dirk-thomas dirk-thomas merged commit ec8b0ef into ros:melodic-devel Aug 8, 2019
meyerj pushed a commit to meyerj/ros_comm that referenced this pull request Dec 22, 2019
Revert "fix base64 encode error (ros#1769)"
cbfc5df 
This reverts commit ec8b0ef.
@meyerj meyerj mentioned this pull request Dec 22, 2019
Merged
dirk-thomas pushed a commit that referenced this pull request Feb 3, 2020
@meyerj @jwakely
Fix base64 decode error on ARM platforms (#1853)
61f0b76 
* Revert "fix base64 encode error (#1769)"

This reverts commit ec8b0ef.

* libb64: integer overflows

Copied from https://sourceforge.net/p/libb64/bugs/2/:
> The attached patch fixes integers overflows in the decoder.
> The first hunk is needed for systems with signed chars (e.g. i386).
> The other hunks fix the decoder on unsigned-char systems (on which it's currently completely broken).

Co-authored-by: Jonathan Wakely <github@kayari.org>
@dirk-thomas dirk-thomas mentioned this pull request Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base64 error on arm
3 participants
@randoms @cwecht @dirk-thomas