Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read GPG passphrase from an environment variable #1856

Merged
merged 2 commits into from Feb 3, 2020

Conversation

nnarain-cpr
Copy link
Contributor

The gnupg library requires users to supply the passphrase for their key as a string into the decrypt function. There currently is no way to supply a passphrase through the rosbag command line tool, meaning only keys without passphrases can be used to decrypt encrypted bags.

This PR enables fetching the passphrase from the environment variable ROSBAG_GPG_PASSPHRASE.

Copy link
Member

@mikepurvis mikepurvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. Down the road, we need to figure out how to get the Python API to rosbag transparently using the gpg agent for the passphrase so that it works the same as how the C++ API does. But this is fine in the short term.

@mikepurvis
Copy link
Member

@dirk-thomas Any concerns here? I doubt anyone else was using gpg keys with the passphrase set to clearpath, so I'd expect this is a safe change.

@dirk-thomas
Copy link
Member

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 3195f1e into ros:melodic-devel Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants