-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mux and Demux to hydro #407
Conversation
That way more than one mux can coexist.
Mainly followed the code from the mux. Added according service descriptions.
Can one of the admins verify this patch? |
// | ||
// Copyright (C) 2009, Morgan Quigley | ||
// Copyright (C) 2014, Andreas Hermann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright should be side by side not replace, even though it's mostly new.
Copyright (C) 2009, Morgan Quigley
Copyright (C) 2014, Andreas Hermann
This comment (https://github.com/Squelsh/ros_comm/blob/hydro-devel/tools/topic_tools/src/mux.cpp#L301) states explicitly that the services are provided on the node "mux" and suggests using remapping in order to use multiple mux instances. This patch would effectively change the public API of the tool which is not a feasible change for Hydro. Even for Indigo it is questionable if that should be changed. The demux part is definitely a good additional. Thank you for porting this functionality. |
Hi Tully, hi Dirk, |
This reverts commit b958d21.
(as suggested by Dirk Thomas). Corrected copyright.
I will add the missing install rule (https://github.com/ros/ros_comm/pull/407/files#diff-ae340f410bae427e1853101dfdbade7eR55) when merging it into indigo-devel. |
For |
I did not notice these scripts till now. Will have a look on monday. |
Wrong button )): However: I don't see the point in a script, where the copyright is three times the lenghts of the script itself, but I committed the according scripts for the demux. |
Merged to indigo-devel in 4edc26b. It will be backported to hydro-devel before the next patch release. Thank you for the PR. |
I was missing a Demux tool. So I brought the old code back to life.
While working on that, I also fixed the service-servers of the Mux tool, so more than one Mux can be used.
Code is tested for hydro. But I think it can also be merged into newer versions. As I have no newer version running, I could not test. ==> Would be nice, if someone could do that.
If my request gets merged, I am happy to update the ROS WIKI page.