Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mux and Demux to hydro #407

Closed
wants to merge 5 commits into from
Closed

Conversation

Squelsh
Copy link

@Squelsh Squelsh commented May 8, 2014

I was missing a Demux tool. So I brought the old code back to life.
While working on that, I also fixed the service-servers of the Mux tool, so more than one Mux can be used.

Code is tested for hydro. But I think it can also be merged into newer versions. As I have no newer version running, I could not test. ==> Would be nice, if someone could do that.

If my request gets merged, I am happy to update the ROS WIKI page.

Andreas Hermann added 2 commits May 8, 2014 23:01
That way more than one mux can coexist.
Mainly followed the code from the mux.
Added according service descriptions.
@ros-pull-request-builder
Copy link
Member

Can one of the admins verify this patch?

//
// Copyright (C) 2009, Morgan Quigley
// Copyright (C) 2014, Andreas Hermann
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright should be side by side not replace, even though it's mostly new.

Copyright (C) 2009, Morgan Quigley
Copyright (C) 2014, Andreas Hermann

@tfoote tfoote changed the title Hydro devel Add Mux and Demux to hydro May 8, 2014
@dirk-thomas
Copy link
Member

This comment (https://github.com/Squelsh/ros_comm/blob/hydro-devel/tools/topic_tools/src/mux.cpp#L301) states explicitly that the services are provided on the node "mux" and suggests using remapping in order to use multiple mux instances.

This patch would effectively change the public API of the tool which is not a feasible change for Hydro. Even for Indigo it is questionable if that should be changed.

The demux part is definitely a good additional. Thank you for porting this functionality.

@Squelsh
Copy link
Author

Squelsh commented May 9, 2014

Hi Tully, hi Dirk,
sorry for the quirks. I totally agree with your comments.
@tfoote : I corrected the Copyright as suggested.
@dirk-thomas : I reverted my changes and adapted the demux to behave the same way as the Mux.

Andreas Hermann added 2 commits May 9, 2014 11:21
@dirk-thomas
Copy link
Member

I will add the missing install rule (https://github.com/ros/ros_comm/pull/407/files#diff-ae340f410bae427e1853101dfdbade7eR55) when merging it into indigo-devel.

@dirk-thomas
Copy link
Member

For mux there are some Python scripts to ease the operations (add, delete, list, select). Wouldn't it make sense to have similar scripts for demux?

@Squelsh
Copy link
Author

Squelsh commented May 9, 2014

I did not notice these scripts till now. Will have a look on monday.

@Squelsh Squelsh closed this May 12, 2014
@Squelsh Squelsh reopened this May 12, 2014
@Squelsh
Copy link
Author

Squelsh commented May 12, 2014

Wrong button )):

However: I don't see the point in a script, where the copyright is three times the lenghts of the script itself, but I committed the according scripts for the demux.

@dirk-thomas
Copy link
Member

Merged to indigo-devel in 4edc26b. It will be backported to hydro-devel before the next patch release. Thank you for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants