roslaunch: Execute .py via roslaunch on windows

[130s]

Migrated from https://code.ros.org/trac/ros/ticket/3422
Attachment available in code.ros.org? : yes

---

Roslaunch can't currently execute python programs on windows because windows doesn't recognise .py as being executable.

The following patches help roslib recognise a .py file as something that can potentially be executed who then passes it off to roslaunch which will recognise the .py as being special (on windows) and prefix the launch command with python (aka python.exe).

After a fair bit of hunting around, this seems to be the best solution I could find. Any other ideas?

[130s]

patch_roslaunch_node_args

1   --- ../roslaunch/node_args.py   2011-03-24 16:25:22.590464992 +0900
2   +++ ./node_args.py      2011-03-24 16:53:09.026465913 +0900
3   @@ -268,5 +268,8 @@
4        logging.getLogger('roslaunch.node_args').info('find_node(%s, %s, %s, %s) took %ss'%(node.package, node.type, machine.ros_root, machine.ros_package_path, (end_t - start_t)))
5        if not cmd:
6            raise NodeParamsException("Cannot locate node of type [%s] in package [%s]"%(node.type, node.package))
7   +    if sys.platform in ['win32']:
8   +        if( os.path.splitext(cmd)[1] == ".py"):
9   +            return _launch_prefix_args(node) + [r"python"]+[cmd] + args       
10       return _launch_prefix_args(node) + [cmd] + args       

[130s]

patch_roslaunch_node_args.2

1   --- ../roslaunch/node_args.py   2011-03-24 16:25:22.590464992 +0900
2   +++ ./node_args.py      2011-03-24 16:53:09.026465913 +0900
3   @@ -268,5 +268,8 @@
4        logging.getLogger('roslaunch.node_args').info('find_node(%s, %s, %s, %s) took %ss'%(node.package, node.type, machine.ros_root, machine.ros_package_path, (end_t - start_t)))
5        if not cmd:
6            raise NodeParamsException("Cannot locate node of type [%s] in package [%s]"%(node.type, node.package))
7   +    if sys.platform in ['win32']:
8   +        if( os.path.splitext(cmd)[1] == ".py"):
9   +            return _launch_prefix_args(node) + [r"python"]+[cmd] + args       
10       return _launch_prefix_args(node) + [cmd] + args    

patch_roslib_packages

1   --- ../roslib/packages.py       2011-03-24 17:10:13.990465387 +0900
2   +++ ./packages.py       2011-03-24 17:14:26.418769226 +0900
3   @@ -510,7 +510,12 @@
4                files = [f.lower() for f in files]
5                for m in matches:
6                    if m in files:
7   -                    test_path = os.path.join(p, node_type)
8   +                    test_path = os.path.join(p,m)
9   +                    # windoze python files aren't labelled executable, return
10  +                    # return these so roslaunch can run them with python.exe
11  +                    if sys.platform in ['win32']:
12  +                        if( os.path.splitext(test_path)[1] == ".py"):
13  +                            return test_path
14                       s = os.stat(test_path)
15                       if (s.st_mode & (stat.S_IRUSR | stat.S_IXUSR) ==
16                           (stat.S_IRUSR | stat.S_IXUSR)):

Changed 22 months ago by snorri

Oops, ignore node_args.2.

Note : this also includes the patch for the bug in #3415.