Added rosbag::Bag::isOpen #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Oct 17, 2017
| @@ -185,6 +185,8 @@ class ROSBAG_DECL Bag | |||
|
|
|||
| void swap(Bag&); | |||
|
|
|||
| bool isOpen() const { return file_.isOpen(); } | |||
There was a problem hiding this comment.
Please keep the implementation of this method in the cpp file even though it is short.
racko
force-pushed
the
added_bag_isOpen
branch
from
1b46aef
to
55689af
Compare
racko
force-pushed
the
added_bag_isOpen
branch
from
55689af
to
f80a7df
Compare
|
Updated |
|
The patch looks good. |
|
@ros-pull-request-builder retest this please |
artivis
pushed a commit
to artivis/ros_comm
that referenced
this pull request
Aug 9, 2019
dirk-thomas
pushed a commit
that referenced
this pull request
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.