Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing zip python3 error #1772

Closed
wants to merge 1 commit into from

Conversation

kalyanvasudev
Copy link

zip returns an iterator in Python3 where as it returns list in Python2.
Thus changing it to be compatible with both Python2 and Python3.

Useful resources - https://stackoverflow.com/questions/27431390/typeerror-zip-object-is-not-subscriptable

zip returns an iterator in Python3 where as it returns list in Python2. 
Thus changing it to be compatible with both Python2 and Python3.
@dirk-thomas dirk-thomas changed the base branch from kinetic-devel to melodic-devel August 12, 2019 21:04
@dirk-thomas
Copy link
Member

I retargeted the melodic-devel branch. Please rebase your patch to cleanly apply.

@kalyanvasudev kalyanvasudev changed the base branch from melodic-devel to kinetic-devel August 12, 2019 21:45
@Tobias-Fischer
Copy link
Contributor

Could this please be merged? I am happy to open a new PR if I should base this on top of a particular branch.
@kalyanvasudev @dirk-thomas

@mikepurvis
Copy link
Member

@Tobias-Fischer Yes, that would be great. Please submit a patch for melodic-devel.

@Tobias-Fischer
Copy link
Contributor

@mikepurvis I just realised that it has already been fixed in #1660

So I think this PR should be closed.

As a side note, however, the bug is still contained in the latest ROS packages on Ubuntu 18.04. How long does it take before the packages pick up those bugfixes?

@mikepurvis
Copy link
Member

The last batch of releases for ros_comm was in August 2018, see: https://github.com/ros-gbp/ros_comm-release

So yes, we're overdue for a release. As far as testing, Clearpath's internal devel fleet was switched to d487d58 about a month ago, and our systems includes both Python 2 and Python 3 usage. We'll have a major internal release in a few weeks after which we can update again.

So depending on @dirk-thomas's availability, I'd suggest a ros_comm release around the end of November. If others want to run ros_comm from source and vouch for the current state of the kinetic-devel branch, that's all the more helpful.

@dirk-thomas
Copy link
Member

Resolved by ##1660.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants