Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/Connection statistic measurements #398

Merged
merged 1 commit into from May 7, 2014
Merged

Topic/Connection statistic measurements #398

merged 1 commit into from May 7, 2014

Conversation

dirk-thomas
Copy link
Member

@forouher FYI

This PR replaces #383. I have:

  • squashed your commits
  • cleaned up some more code
  • and fixed a compilation error with the unit tests in order to run CI

Please provide further patches against this branch.

@dirk-thomas dirk-thomas mentioned this pull request May 5, 2014
Closed
@dirk-thomas
Copy link
Member Author

As @tfoote mentioned on the other PR the name delay seems to be not fitting very well. The timestamp in the header might be much older is e.g. data is played back from a bag file. We would suggest renaming the variable and everything related to something different and would propose age as a better term. @forouher What do you think about that?

@forouher
Copy link
Contributor

forouher commented May 5, 2014

"Age" fits better. "Delay" was what I originally wanted to measure, but I couldn't figure out a way to do it without modifying the TCPROS protocol. Taking the header stamp was the next best thing I could think of. But it's not the same, obviously.

I'll rename the variables etc. to "age".

@forouher @dirk-thomas
add topic/connection statistics
b64458c 
This patch adds a module to roscpp/rospy that monitors some metrics
over every ROS connection (period, dropped messages, traffic, age)
and periodically sends out aggregated statistics data over a common
topic /statistics. It is designed to be lightweight so it can be used
in "production" environments.

Statistics monitoring is disabled by default. It has to be enabled
explicitly using "rosparam set enable_statistics true".
dirk-thomas added a commit that referenced this pull request May 7, 2014
@dirk-thomas
Merge pull request #398 from ros/statistics
7a3f789 
Topic/Connection statistic measurements
@dirk-thomas dirk-thomas merged commit 7a3f789 into indigo-devel May 7, 2014
@dirk-thomas dirk-thomas deleted the statistics branch May 7, 2014 18:26
dirk-thomas added a commit that referenced this pull request May 7, 2014
@dirk-thomas
the latest change requires the upcoming version of rosgraph_msgs (#398)
4532ad8
dirk-thomas added a commit that referenced this pull request May 8, 2014
@dirk-thomas
add queue_size to statistics publisher (#398)
e3fb516
@dirk-thomas
Copy link
Member Author

Can you please add some documentation about this feature to the wiki? Either under ros_comm / roscpp / rospy or the rqt plugin or both - I am not sure where it makes more sense.

dirk-thomas added a commit that referenced this pull request May 8, 2014
@dirk-thomas
fix unit tests due to statistics (#398)
5ea87e2
@forouher
Copy link
Contributor

forouher commented May 9, 2014

Sure, I will amend the wiki (probably at both at ros_comm and rqt_graph with references to each other).

Thanks for merging this!

@dirk-thomas dirk-thomas mentioned this pull request Jul 31, 2014
Merged
@dirk-thomas dirk-thomas mentioned this pull request Feb 23, 2016
Merged
contradict pushed a commit to contradict/ros_comm that referenced this pull request Aug 12, 2016
@dirk-thomas
rqt_console: make message column stretch (ros#398)
fa5b8b5
rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this pull request Jun 19, 2017
@dirk-thomas
Merge pull request ros#398 from ros/statistics
9156cd3 
Topic/Connection statistic measurements
@meyerj meyerj mentioned this pull request Oct 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirk-thomas @forouher