Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Failing to launch python scripts fails with different error #516

Merged
merged 1 commit into from Oct 27, 2014

Conversation

manzato
Copy link
Contributor

@manzato manzato commented Oct 25, 2014

If you forget to add the launch-prefix in a script, roslaunch notices it, but when wants to report the problem, fails to correctly use the exception object. This simple PR fixes this.

@ros-pull-request-builder
Copy link
Member

Can one of the admins verify this patch?

@dirk-thomas
Copy link
Member

Regression of 24e4541

@dirk-thomas
Copy link
Member

@ros-pull-request-builder
Copy link
Member

Test passed.
Refer to this link for build results: http://jenkins.ros.org/job/_pull_request-indigo-ros_comm/139/

@dirk-thomas
Copy link
Member

LGTM

@tfoote @wjwwood Please review.

@tfoote
Copy link
Member

tfoote commented Oct 26, 2014

+1

1 similar comment
@wjwwood
Copy link
Member

wjwwood commented Oct 26, 2014

+1

dirk-thomas added a commit that referenced this pull request Oct 27, 2014
Fix: Failing to launch python scripts fails with different error
@dirk-thomas dirk-thomas merged commit fab4840 into ros:indigo-devel Oct 27, 2014
@manzato manzato deleted the fix-exception-log branch October 29, 2014 14:14
rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this pull request Jun 19, 2017
Fix: Failing to launch python scripts fails with different error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants