Create a symlink to the latest log directory. #659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| def renew_latest_logdir(logfile_dir): | ||
| log_dir = os.path.dirname(logfile_dir) | ||
| latest_dir = os.path.join(log_dir, 'latest') | ||
| if os.path.exists(latest_dir): |
There was a problem hiding this comment.
I don't think this check will work if the symlink exists by points to a not existing folder.
There was a problem hiding this comment.
@dirk-thomas
Thank you for the comment.
I fixed the issue to use os.path.lexists instead of os.path.exists.
* check if latest is actually a symlink before trying to remove it * only try it on non-windows platforms * print better error message depending on the failure case
|
Thanks for the patch. I would like to improve it slightly before merging. Please see yoneken/ros_comm#1 for the suggested changed. |
improve patch
|
@dirk-thomas |
|
Thanks. I have squashed and merged the changes in 28f8361. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes a symbolic link named "latest" to the latest log directory.
Many times I would like to grep error messages in the latest log directory.
This change may make someone's life more easier.