fix location of rosunit result files generated by rostests #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test passed. |
|
@ros/ros_team Please take a look to review this patch. |
|
lgtm |
| test_file = xmlResultsFile(test_pkg, test_name, False) | ||
| env = None | ||
| if results_base_dir: | ||
| env = {ROS_TEST_RESULTS_DIR: results_base_dir} |
There was a problem hiding this comment.
Are there potentially other env values that this is going to override or suppress? It might be better to append to the env instead of overriding it.
There was a problem hiding this comment.
Other code uses the same pattern:
ros_comm/tools/rostest/src/rostest/rostest_main.py
Lines 148 to 154 in 44a089a
And at the end of the call stack only this value is checked: https://github.com/ros-infrastructure/rospkg/blob/d3c12bdfbf990b9910220642bafef16b4c830b63/src/rospkg/environment.py#L162-L166
|
+1 |
1 similar comment
|
+1 |
dirk-thomas
added a commit
that referenced
this pull request
Sep 18, 2015
fix location of rosunit result files generated by rostests
130s
added a commit
to 130s/industrial_ci
that referenced
this pull request
Dec 18, 2015
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
…osunit fix location of rosunit result files generated by rostests
k-okada
added a commit
to k-okada/robot-programming
that referenced
this pull request
Jun 15, 2019
…ostests) has been released ad 1.11.14 see https://github.com/ros/ros_comm/blob/melodic-devel/tools/rostest/CHANGELOG.rst#11114-2015-09-19
k-okada
added a commit
to k-okada/robot-programming
that referenced
this pull request
Jun 15, 2019
…ostests) has been released ad 1.11.14 see https://github.com/ros/ros_comm/blob/melodic-devel/tools/rostest/CHANGELOG.rst#11114-2015-09-19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion from #666 (comment)