Preserve identity of numpy_msg(T)
#743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
patch-1
branch
2 times, most recently
from
9841b77
to
4472096
Compare
This makes `numpy_msg(T) is numpy_msg(T)` always return true. Otherwise, it is impossible to check whether a message is of a numpy type or not, since `isinstance(numpy_msg(T)(), numpy_msg(T))` would always return false
|
Thank you for the patch. I have created #758 which modifies the logic a bit to reduce the diff size to make it easier to review the change. |
|
Great, thanks! |
tobii-ho
pushed a commit
to StarkStrom-Driverless/ros_numpy
that referenced
this pull request
Nov 18, 2023
tobii-ho
pushed a commit
to StarkStrom-Driverless/ros_numpy
that referenced
this pull request
Nov 19, 2023
tobii-ho
pushed a commit
to StarkStrom-Driverless/ros_numpy
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
numpy_msg(T) is numpy_msg(T)always return true.Otherwise, it is impossible to check whether a message is of a numpy type or not, since
isinstance(numpy_msg(T)(), numpy_msg(T))would always return false