Add 'Darwin' to unix-like platforms (resolve #845) #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents issue calling socket.getaddrinfo with the machine name where this is not a known local hostname (e.g. where the machine name hasn't been added to the hosts file).
|
Proposed resolution for #845. |
|
The check is only used in one place that I can see, and that code looks ok for use on OS X. +1 |
|
Thank you for the patch. I have cherry-picked it in 8741260 (and removed the commented line above). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents issue calling socket.getaddrinfo with the machine name where this is not a known local hostname (e.g. where the machine name hasn't been added to the hosts file).