Fix rosservice call for python3.
#847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks ok to me |
|
Thank you for the patch. |
|
Thanks for the quick merge :) |
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
Fix `rosservice call` for python3.
CBJamo
added a commit
to CBJamo/rqt_topic
that referenced
this pull request
Nov 22, 2018
In python 3, message.serialize expects a buffer that will accept a bytes-type input to it's write function. This commit uses the same fix as ros_comm PR #847[1]. [1] ros/ros_comm#847
dirk-thomas
pushed a commit
to ros-visualization/rqt_topic
that referenced
this pull request
Jan 9, 2020
In python 3, message.serialize expects a buffer that will accept a bytes-type input to it's write function. This commit uses the same fix as ros_comm PR #847[1]. [1] ros/ros_comm#847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rosservicewas mistakenly passing a StringIO as buffer torosgraph.network.read_ros_handshake_headereven for python3. For python3 this needs to be a BytesIO object. This PR corrects that.When running with
python2, the oldStringIOtype is still used.