Revert "Using poll() in favor of select() in the XmlRPCDispatcher" #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2017
This was referenced Feb 9, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the head of kinetic-devel fails some tests. I ran several dev jobs (http://build.ros.org/view/Kdev/job/Kdev__ros_comm__ubuntu_xenial_amd64/ builds 102 - 105) for specific hashes to bisect when the problem was introduced and it looks like that PR #833 is the culprit. Therefore this PR revert that change.
We will see if CI will agree and pass again. Then I would propose to merge this in order to test and merge other pending PRs. The change needs to then be applied after it passes CI again.