Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added common tests #154

Merged
merged 2 commits into from Jun 1, 2023
Merged

Added common tests #154

merged 2 commits into from Jun 1, 2023

Conversation

ahcorde
Copy link

@ahcorde ahcorde commented May 24, 2023

Added common tests and applied required changes

@ahcorde
Added common tests
45ae4eb 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from clalancette May 24, 2023 16:52
@ahcorde ahcorde self-assigned this May 24, 2023
@ahcorde
Copy link
Author

ahcorde commented May 25, 2023

compiled up-to turtlesim and test turtlesim.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

clalancette
clalancette reviewed May 25, 2023
View reviewed changes
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question: since we are moving headers around, are there any downstream packages that depend on this package and will break? I don't know if that is the case, but I think it is worthwhile checking before we potentially break them. It's enough to just check on the packages released into Rolling; if there are no users there, then we are safe to do this.

@ahcorde
Copy link
Author

ahcorde commented May 25, 2023

@clalancette These headers are not ament_export_include_directories and I already checked and there is no packages using them. I would say we are safe

@clalancette
Copy link

@clalancette These headers are not ament_export_include_directories and I already checked and there is no packages using them. I would say we are safe

All right, sounds good!

@ahcorde
Fixed Windows build
b097608 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Author

ahcorde commented May 30, 2023

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
Copy link
Author

ahcorde commented May 30, 2023 •
edited by clalancette

Relaunched Windows, it was a failure fetching Qt

  • Windows Build Status

@ahcorde ahcorde merged commit 3c28e07 into rolling Jun 1, 2023
2 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/add_common_test branch June 1, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahcorde @clalancette @mjcarroll