Argument to boost microseconds must be integral in Boost >= 1.67 #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Boost >= 1.67 compilation of roscpp_core fails because boost now requires the
microseconds
constructor argument to be integral.The
git diff boost-1.66.0 include/boost/date_time/time_duration.hpp
in boost date_time git repository confirms that the constructor toboost::date_time::subsecond_duration
was made more stringent:The patch here simply makes it an integer, which should not make any difference, if I'm correct?