Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-pytorch-pip to python.yaml #19382

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Add python-pytorch-pip to python.yaml #19382

merged 1 commit into from
Nov 9, 2018

Conversation

Tobias-Fischer
Copy link
Contributor

This adds torch/torchvision to the python.yaml file. This is for example used by jsk-ros-pkg/jsk_recognition#2041 and seeing the popularity of pyTorch probably in more repositories in the future. Since the old pull request for pyTorch (#14398), the packages have become available in the standard pip.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this in pypi's database this looks ok. Though we will definitely want to switch to an apt based dependency when that becomes available.

@cottsay cottsay merged commit 5a9d7d4 into ros:master Nov 9, 2018
@Tobias-Fischer Tobias-Fischer deleted the patch-1 branch November 12, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants