Add python-face-alignment-pip #19413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Releases cannot use pip rules, they require native package manager rules. Will this still be useful? |
|
Yes it'd still be useful. Would be great if we can add it. |
tfoote
requested changes
Nov 8, 2018
There was a problem hiding this comment.
Ok, then pleas fix your indentation to be consistent with the rest of the file. The tests are failing due to incorrect indententation.
Also please provide links to the package and double check your submission against the CONTRIBUTING guidelines: https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md
|
Sorry for that. Indentation fixed. Thanks |
cottsay
approved these changes
Nov 9, 2018
tfoote
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be required in a package that we plan to release soon.