-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
melodic: migrate abb_driver to new repository #25545
Conversation
Related: #25544. |
This migrates abb_driver from ros-industrial/abb to ros-industrial/abb_driver. Manual merge, as Bloom won't release an already released package from a different location.
Short answer: I think it will work for rosinstall generator but cause us problems when building binarydeb packages. It looks like @gavanderhoorn has already updated the PR but for completeness here's why: The platform- and distribution-specific information is usually found in the debian/* and rpm/* branches. The release/ branches are meant to be platform independent but still give a chance for release patches against upstream source. It's possible to add other entries to tags here: for example one specific to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with the tags updated now.
@nuclearsandwich is right that it would break the debian builds having the wrong tags. It's the most common error when people manually create PRs instead of using the bloom ones.
I'm (and was) fully aware of this. It was simply a case of getting the release branch in the repository mixed up with the release branch in the release repository. |
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/migration-of-abb-driver-to-a-separate-repository/13522/3 |
As per subject.
This PR combines a Bloom release of
ros-industrial/abb_driver
and the removal of the same packages from theros-industrial/abb
repository in a single commit.The
release
entry was created manually, as Bloom doesn't let me release a package which is already part of a releases repository (and rightfully so).