Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python3-lgsvl-lib in 'rosdep/python3.yaml' #29134

Closed
wants to merge 1 commit into from

Conversation

yanrayw
Copy link
Contributor

@yanrayw yanrayw commented Apr 14, 2021

Add lgsvl(Python API) in python3.yaml to install third-party-librarys by
rosdep. Those libs aim to control SVL simulator by python script.

Please add the following dependency to the rosdep database.

Package name:

A Python API of lgsvl to control SVL Simulator by python script.

Package Upstream Source:

https://github.com/lgsvl/PythonAPI

Purpose of using this:

Some people might use source code to install ros2 foxy and autoware.auto. This dependency helps them to install simulator-related libraries easily. This dependency is being used for this reason. This is why I think it's valuable to be added to the rosdep database.

Distro packaging links:

Links to Distribution Packages

Not sure on this point.

Please Add This Package to be indexed in the rosdistro.

https://github.com/YanrayWang/rosdistro/blob/master/rosdep/python.yaml#L6257

The source is here:

https://github.com/lgsvl/PythonAPI

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

Note

This is not a standard python library installed by pip/pip3. But it does a python third-party-library. I found there is no github links in rosdep/python3.yaml. It looks fine the rosdep would use sudo -H pip3 install -U git+https://github.com/lgsvl/PythonAPI.git to install the libraries. However, I still need to pin the version so I added 2021.1. I'm not sure whether this would work. Furthermore, I found out when installation is done, it prints Successfully installed lgsvl-0.0.0 ERROR: the following rosdeps failed to install pip: Failed to detect successful installation of [git+https://github.com/lgsvl/PythonAPI.git] I think it's not a standard library, so it's not detected by rosdep, is it right? Please help me with this, appreciate it!

Add lgsvl(Python API) in python3.yaml to install third-party-librarys by
rosdep. Those libs aim to control SVL simulator by python script.
@yanrayw yanrayw requested a review from a team as a code owner April 14, 2021 02:55
@cottsay cottsay added the rosdep Issue/PR is for a rosdep key label Apr 14, 2021
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The pip logic in rosdep isn't able to handle detecting packages in this way. Even if installation is possible, rosdep will give an error because it can't verify the installation. As of now, only installation by Python package name is possible.
  2. Packages coming from pip should have the -pip suffix on the key name. Please take a look at the CONTRIBUTING.md for details.

@cottsay cottsay added the changes requested Maintainers have asked for changes to the pull request label Apr 14, 2021
@yanrayw
Copy link
Contributor Author

yanrayw commented Apr 15, 2021

  1. The pip logic in rosdep isn't able to handle detecting packages in this way. Even if installation is possible, rosdep will give an error because it can't verify the installation. As of now, only installation by Python package name is possible.
  2. Packages coming from pip should have the -pip suffix on the key name. Please take a look at the CONTRIBUTING.md for details.

Hi, @cottsay , thanks for reply. Is there a reference to add third-party library in rosdep? Since it's a github link not a general pip packages. Should I add it somewhere else?

@cottsay
Copy link
Member

cottsay commented Apr 15, 2021

Is there a reference to add third-party library in rosdep?

There is no reference. It is not supported. Only installation of packages in pypi.org is supported.

@yanrayw yanrayw closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants