add python3-lgsvl-lib in 'rosdep/python3.yaml' #29134
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lgsvl(Python API) in python3.yaml to install third-party-librarys by
rosdep. Those libs aim to control SVL simulator by python script.
Please add the following dependency to the rosdep database.
Package name:
A Python API of lgsvl to control SVL Simulator by python script.
Package Upstream Source:
https://github.com/lgsvl/PythonAPI
Purpose of using this:
Some people might use source code to install ros2 foxy and autoware.auto. This dependency helps them to install simulator-related libraries easily. This dependency is being used for this reason. This is why I think it's valuable to be added to the rosdep database.
Distro packaging links:
Links to Distribution Packages
Not sure on this point.
Please Add This Package to be indexed in the rosdistro.
https://github.com/YanrayWang/rosdistro/blob/master/rosdep/python.yaml#L6257
The source is here:
https://github.com/lgsvl/PythonAPI
Checks
Note
This is not a standard python library installed by pip/pip3. But it does a python third-party-library. I found there is no github links in rosdep/python3.yaml. It looks fine the rosdep would use
sudo -H pip3 install -U git+https://github.com/lgsvl/PythonAPI.git
to install the libraries. However, I still need to pin the version so I added 2021.1. I'm not sure whether this would work. Furthermore, I found out when installation is done, it printsSuccessfully installed lgsvl-0.0.0 ERROR: the following rosdeps failed to install pip: Failed to detect successful installation of [git+https://github.com/lgsvl/PythonAPI.git]
I think it's not a standard library, so it's not detected by rosdep, is it right? Please help me with this, appreciate it!