-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python3-mlflow to rosdep #29514
Add python3-mlflow to rosdep #29514
Conversation
FYI @yotabits |
packages: [mlflow] | ||
ubuntu: | ||
pip: | ||
packages: [mlflow] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@n-meunier mind to add an entry for OSX and Gentoo? BTW it appears there's mlflow
1.11.0 on OpenSUSE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. I'm gonna add an entry for OSX and OpenSUSE.
For Gentoo, I could not find the package in https://packages.gentoo.org/. Isn't it the condition for this entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it doesn't look like we can use anything but pip
on Gentoo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found any other example with:
gentoo:
pip:
packages:
But I added it following your comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My impression is that gentoo doesn't like alternative installers like pip. @allenh1 Can you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My impression is that gentoo doesn't like alternative installers like pip.
Yeah, you shouldn't install things with pip on gentoo. These days, if you attempt to run pip install you get an error message.
ERROR: (Gentoo) Please run pip with the --user option to avoid breaking python-exec
Previously it would just break your package manager 🙃.
What we can do, though, is create a package in the overlay repo. We've done this for a few deps. I'll make an issue there for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a ticket to release the dependency here. In the meantime, feel free to merge without a gentoo resolution, as there unfortunately isn't one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the ticket and your explanation.
Rename package from python3-mlflow-pip to python3-mlfow since it is not only pip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me. @wjwwood ?
This reverts commit 3fff709.
Please add the following dependency to the rosdep database.
Package name:
python3-mlflow-pip
Edit: since it is not only available with
pip
, new name ispython3-mlflow
.Package Upstream Source:
https://pypi.org/project/mlflow/
https://build.opensuse.org/package/show/home:jayvdb:py-new/python-mlflow
Purpose of using this:
https://pypi.org/project/mlflow/#description
A platform to manage Machine Learning models and experiments.
Distro packaging links:
Links to Distribution Packages