Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3-mlflow to rosdep #29514

Merged
merged 4 commits into from
May 21, 2021
Merged

Conversation

n-meunier
Copy link
Contributor

@n-meunier n-meunier commented May 13, 2021

Please add the following dependency to the rosdep database.

Package name:

python3-mlflow-pip
Edit: since it is not only available with pip, new name is python3-mlflow.

Package Upstream Source:

https://pypi.org/project/mlflow/
https://build.opensuse.org/package/show/home:jayvdb:py-new/python-mlflow

Purpose of using this:

https://pypi.org/project/mlflow/#description

A platform to manage Machine Learning models and experiments.

Distro packaging links:

Links to Distribution Packages

@n-meunier n-meunier requested a review from a team as a code owner May 13, 2021 00:59
@n-meunier
Copy link
Contributor Author

FYI @yotabits

packages: [mlflow]
ubuntu:
pip:
packages: [mlflow]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n-meunier mind to add an entry for OSX and Gentoo? BTW it appears there's mlflow 1.11.0 on OpenSUSE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I'm gonna add an entry for OSX and OpenSUSE.
For Gentoo, I could not find the package in https://packages.gentoo.org/. Isn't it the condition for this entry?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it doesn't look like we can use anything but pip on Gentoo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any other example with:

  gentoo:
    pip:
      packages: 

But I added it following your comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My impression is that gentoo doesn't like alternative installers like pip. @allenh1 Can you confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My impression is that gentoo doesn't like alternative installers like pip.

Yeah, you shouldn't install things with pip on gentoo. These days, if you attempt to run pip install you get an error message.

ERROR: (Gentoo) Please run pip with the --user option to avoid breaking python-exec

Previously it would just break your package manager 🙃.

What we can do, though, is create a package in the overlay repo. We've done this for a few deps. I'll make an issue there for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a ticket to release the dependency here. In the meantime, feel free to merge without a gentoo resolution, as there unfortunately isn't one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the ticket and your explanation.

@hidmic hidmic requested a review from wjwwood May 13, 2021 20:12
@hidmic hidmic added the rosdep Issue/PR is for a rosdep key label May 13, 2021
@wjwwood wjwwood added the changes requested Maintainers have asked for changes to the pull request label May 13, 2021
Rename package from python3-mlflow-pip to python3-mlfow since it is not only pip
@n-meunier n-meunier changed the title Add python3-mlflow-pip to rosdep Add python3-mlflow to rosdep May 14, 2021
@n-meunier n-meunier requested review from hidmic and removed request for a team May 18, 2021 06:45
@hidmic hidmic removed the changes requested Maintainers have asked for changes to the pull request label May 18, 2021
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. @wjwwood ?

This reverts commit 3fff709.
@n-meunier
Copy link
Contributor Author

@tfoote @allenh1 thank you for the review, I reverted the Gentoo entry.

@wjwwood wjwwood removed their request for review May 21, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants