-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtualserialports to python.yaml #29587
Conversation
Signed-off-by: Gabriel Gaessler <gabriel.gaessler@de.bosch.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just approved the CI run.
One request though. Unless you're going to be using the python2 version we shouldn't add it. I believe all platforms have moved to python3 now and adding the extra rule that's unused will just require cleanup in the future.
Signed-off-by: Gabriel Gaessler <gabriel.gaessler@de.bosch.com>
I just put it in for backwards compatibility. I'm not needing it. Just removed the Python2 part. |
Signed-off-by: Gabriel Gaessler <gabriel.gaessler@de.bosch.com>
Not sure why the test is failing. Looks like a new test. Could you do a merge from |
…rtualserialports
Merged it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks passed
Please add the following dependency to the rosdep database.
Package name:
python-virtualserialports-pippython3-virtualserialports-pip
Package Upstream Source:
https://github.com/ezramorris/PyVirtualSerialPorts
Purpose of using this:
Testing ROS serial device drivers.
Distro packaging links:
Links to Distribution Packages
Only available through PyPI: https://pypi.org/project/PyVirtualSerialPorts/