Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ur_robot_driver: 2.3.3-1 in 'iron/distribution.yaml' [bloom] #38335

Merged
merged 2 commits into from Aug 24, 2023

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Aug 23, 2023

Increasing version of package(s) in repository ur_robot_driver to 2.3.3-1:

ur

  • No changes

ur_calibration

  • No changes

ur_controllers

* Handle api changes related to traj_external_point_ptr_ (#779 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/779>)
  * Handle api changes related to traj_external_point_ptr_
  * Fix formatting
  ---------
  Co-authored-by: Robert Wilbrandt <mailto:wilbrandt@fzi.de>
  (cherry picked from commit e2b22b15ca627cfb375c3d58e585e1d3dee5f484)
* Contributors: Yadu

ur_dashboard_msgs

  • No changes

ur_moveit_config

  • No changes

ur_robot_driver

* Run robot driver test also with tf_prefix (#729 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/729>) (#752 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/752>)
  * Run robot driver test also with tf_prefix
  * Use tf_prefix substitution in controllers config file
  * Set default value of tf_prefix in launchfile to empty instead of '""'
  ---------
  Co-authored-by: Robert Wilbrandt <mailto:wilbrandt@fzi.de>
  (cherry picked from commit 79bfddc7ac4cd3a69594da26ce6ae8b8024eae73)
  Co-authored-by: Felix Exner (fexner) <mailto:exner@fzi.de>
* Urscript interface (#721 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/721>)
  * Add a urscript interface node
  * Add urscript_interface to standard launchfile
  * Added documentation for urscript_interface
  * Add a notice about incorrect script code
  * Add test for urscript interface
  * Move tests to one single tests
  This should avoid that different tests run in parallel
  * Wait for IO controller before checking IOs
  * Write an initial textmessage when connecting the urscript_interface
  * Wait for controller_manager services longer
  * Make sure we have a clean robot state without any program running once we enter our test
  similar to how we did it on the robot_driver test
  * Remove unneeded Destructor definition
* Use SCHED_FIFO for controller_manager's main thread (#719 <https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/719>)
  Previous investigations showed that using FIFO scheduling helps keeping
  cycle times also non non-RT kernels. This combined with non-blocking read
  can result in a very stable system.
  This is, in fact, very close to what the actual controller_manager_node
  does except that we always use FIFO scheduling independent of the actual
  kernel in use.
* Contributors: Felix Exner (fexner), mergify[bot]

@github-actions github-actions bot added the iron Issue/PR is for the ROS 2 Iron distribution label Aug 23, 2023
iron was forked out recently.
@fmauch
Copy link
Contributor Author

fmauch commented Aug 23, 2023

This should fix the current regressions on the Iron release.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/preparing-for-iron-sync-2023-08-25/33047/2

@mjcarroll
Copy link
Member

Holding for Iron sync

@mjcarroll mjcarroll added the held for sync Issue/PR has been held because the distribution is in a sync hold label Aug 23, 2023
@mjcarroll
Copy link
Member

Actually, I will defer to @Yadunund (iron rosboss) for what he wants to do here.

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly blooming this patch with the fixes needed to unblock the sync!

@Yadunund Yadunund merged commit 48793b2 into ros:master Aug 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
held for sync Issue/PR has been held because the distribution is in a sync hold iron Issue/PR is for the ROS 2 Iron distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants