Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ros2_easy_test #41661

Merged
merged 1 commit into from
Jul 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions rolling/distribution.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5834,6 +5834,16 @@ repositories:
url: https://github.com/ros-controls/ros2_controllers.git
version: master
status: developed
ros2_easy_test:
doc:
type: git
url: https://github.com/felixdivo/ros2-easy-test.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually wanted to add https://ros2-easy-test.readthedocs.io here, but I think only type: git is supported?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Timple yes, this registry is specifically for build farm generated docs with rosdoc2 (for ROS 2) and the most supported case is using the source repository as the documentation source, generating and uploading docs to docs.ros.org.

I genuinely thought that there was a "documentation" type for <url>s in package.xml but it's not in https://www.ros.org/reps/rep-0149.html#url-multiple, if you set your readthedocs site as the project website it will be linked as the project website on index.ros.org and you can link it from the generated API docs / project readme as well which should help direct people.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll solve that in the package.xml then. But that's not a blocker for this PR right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is merged into main thanks to @Timple's felixdivo/ros2-easy-test#47

version: main
source:
type: git
url: https://github.com/felixdivo/ros2-easy-test.git
version: main
status: developed
ros2_kortex:
doc:
type: git
Expand Down
Loading