Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually wanted to add https://ros2-easy-test.readthedocs.io here, but I think only
type: git
is supported?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Timple yes, this registry is specifically for build farm generated docs with rosdoc2 (for ROS 2) and the most supported case is using the source repository as the documentation source, generating and uploading docs to docs.ros.org.
I genuinely thought that there was a "documentation" type for
<url>
s in package.xml but it's not in https://www.ros.org/reps/rep-0149.html#url-multiple, if you set your readthedocs site as the project website it will be linked as the project website on index.ros.org and you can link it from the generated API docs / project readme as well which should help direct people.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll solve that in the package.xml then. But that's not a blocker for this PR right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is merged into
main
thanks to @Timple's felixdivo/ros2-easy-test#47