Fix issue #6: No robot model when using display.launch (again) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping? |
isucan
added a commit
that referenced
this pull request
Jan 9, 2014
…stall Fix issue #6: No robot model when using display.launch (again)
|
Thanks. Should we update the tutorial pages now, or when this is released? |
|
Can you update it now? I will trigger a release now for Hydro. Should I release for Groovy as well? |
|
I can update them.
Well AFAIK the package is currently broken in both Hydro and Groovy, so I guess it should be rereleased in both? |
|
I've updated the wiki pages I could find. There are still some bits that seem outdated (references to |
|
Packages released for both hydro & groovy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should actually fix the issues. I think the proposed file and directory layout is in line with other packages containing URDFs and launch files.
Doing it this way does require us updating the tutorials, as the URDFs are now in the
urdfsubdirectory.PS: I left the
urdf.vcgfile in, although AFAIK those are not used anymore (old RViz config file?).