Update gtest to 1.10.0 version #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ROS2 CI:
|
clalancette
approved these changes
Sep 22, 2021
|
Another try:
|
j-rivero
force-pushed
the
jrivero/ros2-merge-fixes2-gtest-1.10
branch
from
aece008
to
c5ab9ab
Compare
|
Branch was not updated. Rebased:
|
clalancette
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
CI looks good to me, so approving. What I'll suggest to get this in is:
- Merge Unify master and ros2 branches (merge ros2 into master) #158
- Rebase this one on top of master
- Merge this one
- Update https://github.com/ros2/ros2/blob/master/ros2.repos to point to the master branch here.
- Tag this repository and do a source release. I'll suggest bumping the major version to 3.0.
- Do a release of this package into Rolling.
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
clalancette
force-pushed
the
jrivero/ros2-merge-fixes2-gtest-1.10
branch
from
c5ab9ab
to
692a0b8
Compare
|
All right, I've approved, CI is green, and I verified that the changes before and after the rebase are 100% the same. So this is good to go, I'm going to go ahead and merge. Thanks @j-rivero . |
clalancette
added a commit
to ros2/ros2
that referenced
this pull request
Sep 24, 2021
In ros/urdfdom#158 and ros/urdfdom#161, we merged the ros2 branch onto the master branch so there would be single, unified release branch for all of urdfdom. Now that that is done, we should switch to using the master branch of urdfdom.
clalancette
added a commit
to ros2/ros2
that referenced
this pull request
Sep 27, 2021
In ros/urdfdom#158 and ros/urdfdom#161, we merged the ros2 branch onto the master branch so there would be single, unified release branch for all of urdfdom. Now that that is done, we should switch to using the master branch of urdfdom.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #158 (review)
Two commits on top of pull #158:
comparison of integer expressions of different signedness