Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xacro --includes gives warning to use --inorder processing, which is not possible #149

Closed
mrjogo opened this issue Apr 14, 2017 · 6 comments

Comments

@mrjogo
Copy link

mrjogo commented Apr 14, 2017

Running the xacro --includes command gives the warning

xacro: Traditional processing is deprecated. Switch to --inorder processing!
To check for compatibility of your document, use option --check-order.
For more infos, see http://wiki.ros.org/xacro#Processing_Order

But running xacro --includes --inorder gives the error

xacro: error: options --inorder and --includes are mutually exclusive
@rhaschke
Copy link
Contributor

I guess you would like to suppress the deprecation warning when the --includes option is used?

@mrjogo
Copy link
Author

mrjogo commented Apr 14, 2017

If that's the right resolution. I'm unclear if --includes somehow breaks the assumptions of --inorder processing. Ie, if a file is processed first with xacro --includes and then with xacro --inorder is it equivalent to just processing it with xacro --inorder.

@rhaschke
Copy link
Contributor

Good point. Usually, xacro --includes | xacro --inorder should yield the same result as xacro --inorder.
However, if one uses ${} expressions for the filename argument of the <include> tag, this obviously requires prior (inorder) processing of the document to resolve the variable filename.
But combining both options, --inorder and --include, to cover this case as well, doesn't make sense: inorder-processing would already modify the document (evaluate expressions + macros), which is not intended by the --include option. That's why both options are mutually exclusive.

@mrjogo
Copy link
Author

mrjogo commented Apr 26, 2017

Ah, I understand now. Thanks!

codebot added a commit that referenced this issue Aug 25, 2017
@raequin
Copy link

raequin commented Mar 23, 2018

Please tell me, if you're able, where I can learn about "traditional processing" vs using the --inorder flag.

@rhaschke
Copy link
Contributor

Did you have a look into the wiki?

rhaschke added a commit to ubi-agni/xacro that referenced this issue Mar 27, 2018
* suppress --inorder deprecation warning when --includes option is given
  fixes ros#149

* do not complain about extra attributes that are namespace specifiers
  fixes ros#148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants