Fix resolving of macros declared and called in/from a namespace #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given two macros, declared in a namespace-included file, from outside they can only be accessed using the namespace prefix. However, when calling one macro from the other (within the namespace), the namespace prefix shouldn't be required anymore (it's not even known). To fix this issue, the macros dict needs to be updated during resolution.
rhaschke
added a commit
to ubi-agni/xacro
that referenced
this pull request
Jan 19, 2022
This is a follow-up of ros#297, which resolved a corresponding issue for macro names only. As we have separate dicts for macros and symbols, we need to resolve both of them.
rhaschke
added a commit
to ubi-agni/xacro
that referenced
this pull request
Jan 19, 2022
This is a follow-up of ros#297, which resolved a corresponding issue for macro names only. As we have separate dicts for macros and symbols, we need to resolve both of them.
rhaschke
added a commit
that referenced
this pull request
Jan 20, 2022
This is a follow-up of #297, which resolved a corresponding issue for macro names only. As we have separate dicts for macros and symbols, we need to resolve both of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given two macros, declared in a namespace-included file,
from outside they can only be accessed using the namespace prefix.
However, when calling one macro from the other (within the namespace),
the namespace prefix shouldn't be required anymore (it's not even known).
To fix this issue, the macros dict needs to be updated during resolution.
Fixes #296.
Note: macros declared outside the namespace will not be accessible anymore!