Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested types #10

Closed
wants to merge 9 commits into from
Closed

Nested types #10

wants to merge 9 commits into from

Conversation

fmrico
Copy link
Contributor

@fmrico fmrico commented Jan 26, 2019

Hi @esteve ,

I have implemented the publication and subscription to Nested Types.

Hope it helps!!

@fmrico
Copy link
Contributor Author

fmrico commented Jan 27, 2019

I have just detected an error. Please, wait for my next commits :S

@fmrico
Copy link
Contributor Author

fmrico commented Jan 27, 2019

Hi @esteve ,

I have fixed the error and now write and read and recursively done.

Best

@fmrico fmrico mentioned this pull request Jan 30, 2019
@esteve
Copy link
Member

esteve commented Jan 30, 2019

Thanks for the PR.

rosidl_generator_dotnet/resource/msg.cs.em Outdated Show resolved Hide resolved
rosidl_generator_dotnet/resource/msg.cs.em Show resolved Hide resolved
@esteve
Copy link
Member

esteve commented Jan 30, 2019

@fmrico could you add a few simple tests with xUnit to check that everything is correct? This code is extremely delicate, and it'd be good to make sure that nothing breaks in the future.

@fmrico
Copy link
Contributor Author

fmrico commented Feb 15, 2019

@esteve , I added xUnit tests, as you requested. It depends on a PR made in ros2-dotnet/dotnet_cmake_module#2

By now, tests must be in a separate package, and tests are run by typing:
$ dotnet test ./build/rcldotnet_tests/

I don't know if you have time to help me to integrate it with ament...

Hope it helps!!

rcldotnet_tests/package.xml Outdated Show resolved Hide resolved
Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
@fmrico
Copy link
Contributor Author

fmrico commented Mar 1, 2019

I am happy to say that I think I got it !! Tests are integrated with ament :)

This PR depends on ros2-dotnet/dotnet_cmake_module#2

I also fixed a problem that didn't allow to create two projects in the same package with different TargetFramework

@theseankelly
Copy link
Member

theseankelly commented Dec 8, 2019

FYI @fmrico, @esteve -- I have rebased this work on top of PRs #40 and #41 in this branch: https://github.com/theseankelly/ros2_dotnet/commits/nested_types_rebased

@fmrico
Copy link
Contributor Author

fmrico commented Dec 9, 2019

Dear @theseankelly

Thanks for your work ;)

Maybe it will be useful for you this other branch if you also want to support collection types, or even this that I worked on for supporting tf2.

I promised @esteve to PR all these developments, but I have been very busy this year with a lot of projects. I am happy to see how you push forward the amazing Esteve's work with this repo.

Best regards

@theseankelly theseankelly added this to Waiting/Work Needed in Project Status Mar 27, 2020
@theseankelly
Copy link
Member

This was done in #54

Project Status automation moved this from Waiting/Work Needed to Done May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants