Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for nested types #54

Merged
merged 7 commits into from
Apr 27, 2020
Merged

Support for nested types #54

merged 7 commits into from
Apr 27, 2020

Conversation

fmrico
Copy link
Contributor

@fmrico fmrico commented Mar 30, 2020

Hi!!

This PR provides support for nested types.

Best

Signed-off-by: Francisco Martin Rico fmrico@gmail.com

@fmrico
Support for nested types
856c1f7 
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
@fmrico fmrico mentioned this pull request Mar 30, 2020
Closed
@esteve
Copy link
Member

esteve commented Mar 30, 2020

@fmrico thanks! Could you add some tests to this PR?

@fmrico
Copy link
Contributor Author

fmrico commented Mar 30, 2020

Ok!! It will take me some time, but I will start working now on it.

@fmrico
Add tests with XUnit
b253af8 
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
@fmrico
Copy link
Contributor Author

fmrico commented Mar 30, 2020

Hi @esteve ,

Tests added, but it depends on ros2-dotnet/dotnet_cmake_module#2

Best!!

theseankelly
theseankelly requested changes Apr 26, 2020
View reviewed changes
Copy link
Member

@theseankelly theseankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor points but otherwise looks great; thanks for doing the work and for rebasing it again after the Eloquent changes!!

rosidl_generator_dotnet/resource/msg.c.em Outdated Show resolved Hide resolved
rosidl_generator_dotnet/resource/msg.c.em Show resolved Hide resolved
rosidl_generator_dotnet/resource/msg.cs.em Outdated Show resolved Hide resolved
rosidl_generator_dotnet/resource/msg.cs.em Outdated Show resolved Hide resolved
rosidl_generator_dotnet/resource/msg.h.em Outdated Show resolved Hide resolved
@theseankelly
Copy link
Member

Thanks for this change, and also for laying the groundwork to do some unit testing.

@fmrico
Merge pull request #4 from theseankelly/fmrico-eloquent_nested_types_…
0b76aba 
…_get_dotnet_type_patch

Extend get_dotnet_type to handle nested types
@fmrico
Fix minor fixes
b050030 
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
@fmrico
Merge with Sean PR
d04dfee 
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
@fmrico
Remove __native in names
5b5ee88 
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
@fmrico
Copy link
Contributor Author

fmrico commented Apr 26, 2020

I think that everything is pushed to PR, both here and in dotnet_cmake_module.

Thanks to you for your comments and revisions!!!

I am willing to start working in the collections :)

@theseankelly theseankelly merged commit 4043f2f into ros2-dotnet:master Apr 27, 2020
@fmrico fmrico deleted the eloquent_nested_types branch April 27, 2020 17:23
@theseankelly theseankelly mentioned this pull request May 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseankelly theseankelly theseankelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmrico @esteve @theseankelly