-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rosidl_runtime_rs differences between main and crate breaks colcon build #303
Comments
Thanks for the report! I'm trying to understand how the two versions got mixed – could you tell me how you depend on |
Ok while typing the answer I realized that you were talking about Anyway it seems to not be an issue with |
After a quick search, this might even be just a bug in |
Hi so I tried to get this up and running to test out integrating it with our existing ros codebase and ran into the following issue:
![image](https://user-images.githubusercontent.com/5814041/221580740-1a33322e-53fc-45a4-bdbb-aab7779c5d78.png)
It seems the removal of libc (#284) and thus change of the
get_type_support
to return*const std::os::raw::c_void
leads to the build breaking:After some investigation this is only due to the latest release 0.3.1 installed from crates.io not having this change yet.
As such this is only an issue during local development on the main branch and might just be due to my limited knowledge of rust/cargo.
However it was very confusing for me that
rosidl_runtime_rs
is downloaded and is used instead of the local one built withcolcon build
.The section in the documentation does not seem up to date. As I understand the
rosidl_runtime_rs
crate did not use to exist?By changing
Cargo.toml
ofrclrs
to userosidl_runtime_rs = { version = 0.3, path = "../rosidl_runtime_rs" }
I'm able to build with bothcolcon build
as well ascargo build
.Would this be the correct way to fix this? As I take it from the docs this lead to issues in the past, due to colcon utilzing the name of packages as identifier?
I'm happy to do a PR with documenation and/or other changes if you could point me to the correct way to address this problem.
The text was updated successfully, but these errors were encountered: