Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Arc from the create_node function to match other create_X functions #294

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Return Arc from the create_node function to match other create_X functions #294

merged 4 commits into from
Jul 25, 2023

Conversation

esteve
Copy link
Collaborator

@esteve esteve commented Nov 27, 2022

This PR makes create_node consistent with other create_X functions by return an Arc. Additionally added fine-grained locks so that create_X functions don't need to take a mutable reference to self.

Returning an Arc is also akin to rclcpp's behavior, which returns a shared_ptr from create_node.

@esteve esteve force-pushed the create-node-arc branch 4 times, most recently from 80a437b to bc88283 Compare November 28, 2022 14:54
@esteve esteve marked this pull request as ready for review July 25, 2023 13:21
@esteve esteve requested review from maspe36 and jhdcs July 25, 2023 13:21
jhdcs
jhdcs approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me! Thank you very much!

@esteve esteve changed the title Return Arc to match create_node function other create_X functions Return Arc from the create_node function to match other create_X functions Jul 25, 2023
@esteve
Copy link
Collaborator Author

esteve commented Jul 25, 2023

@jhdcs thanks for the prompt review!

@esteve esteve merged commit 7450810 into main Jul 25, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the create-node-arc branch July 25, 2023 20:40
@maspe36 maspe36 mentioned this pull request Oct 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhdcs jhdcs jhdcs approved these changes

@maspe36 maspe36 Awaiting requested review from maspe36

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@esteve @jhdcs