Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

Xenial release nightlies time/clock failures #147

Closed
dhood opened this issue Sep 13, 2018 · 2 comments
Closed

Xenial release nightlies time/clock failures #147

dhood opened this issue Sep 13, 2018 · 2 comments
Assignees

Comments

@dhood
Copy link
Member

dhood commented Sep 13, 2018

These tests started failing august 29:

projectroot.cppcheck
projectroot.rclpytests
rclpy.test.test_clock.TestClock.test_triggered_clock_change_callbacks
rclpy.test.test_clock.TestClock.test_triggered_time_jump_callbacks
rclpy.test.test_time_source.TestTimeSource.test_backwards_jump
rclpy.test.test_time_source.TestTimeSource.test_clock_change
rclpy.test.test_time_source.TestTimeSource.test_forwards_jump
rclpy.test.test_time_source.TestTimeSource.test_no_post_callback
rclpy.test.test_time_source.TestTimeSource.test_no_pre_callback
rclcpp.cppcheck.error: deallocret (src/rclcpp/clock.cpp:138)

https://ci.ros2.org/view/nightly/job/nightly_xenial_linux_release/82/
https://ci.ros2.org/view/nightly/job/nightly_xenial_linux-aarch64_release/87/

Which was after these PRs were merged (cc @sloretz):
ros2/rclpy#222 (adding some of the tests)
ros2/rclcpp#543
ros2/rcl#284

@sloretz
Copy link

sloretz commented Sep 13, 2018

All tests are fixed by ros2/rclpy#237 and ros2/rclcpp#556. I think this can be closed when both are merged.

@dhood
Copy link
Member Author

dhood commented Sep 20, 2018

am going to close this under the assumption the xenial nightlies will go back to green tonight; can reopen it if not.

@dhood dhood closed this as completed Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants