Add methods on Mock class for Python 3.5 compatibility #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
added
in progress
|
Looks like CI is quick, CI testing just rclpy
|
|
You don't need a subclass you could just add the methods to the existing class. |
|
@dirk-thomas monkey patch instead of subclass in acc2065 |
sloretz
commented
Sep 13, 2018
rclpy/test/test_clock.py
Outdated
| @@ -23,6 +23,8 @@ | |||
| from rclpy.duration import Duration | |||
| from rclpy.time import Time | |||
|
|
|||
| from .mock_compat import * # noqa | |||
There was a problem hiding this comment.
Can't do import .mock_compat becase PEP 328 forbids it, and can't do import mock_compat because pytest doesn't put the test directory into sys.path.
There was a problem hiding this comment.
Only suppress the specific category rather than a blank noqa.
There was a problem hiding this comment.
6d8381d gets rid of the * so flake8 can detected undefined names and ignores the specific violation of variable _ being unused.
dirk-thomas
approved these changes
Sep 13, 2018
This was referenced Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some test failures on xenial caused by #222. The tests used methods on
unittest.mock.Mockthat were added in python 3.6. This PR ~~~adds a subclass with those methods defined~~~ monkey patches those methods onto the mock class if they are not present.Xenial CI just rclpy
CI bionic just rclpy
Will run full CI post review
Connects to ros2/build_farmer#147