Flake8 errors on nightly jobs

[clalancette]

There are new flake8 errors on the nightly jobs; here's one example: https://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_debug/788/testReport/junit/rosidl_generator_py/flake8_rosidl_generated_py/Q003___home_jenkins_workspace_nightly_linux_aarch64_debug_ws_build_rosidl_generator_py_rosidl_generator_py_rosidl_generator_py_msg__strings_py_45_37_/

It's not entirely clear to me where that change is coming from; there were two patches merged into rosidl stuff on April 16 (here and here), but both seem to be benign. Needs to be looked into.

[dirk-thomas]

There are new flake8 errors on the nightly jobs; here's one example: https://ci.ros2.org/view/nightly/job/nightly_linux-aarch64_debug/788/testReport/junit/(root)/projectroot/flake8_rosidl_generated_py/ .

The page you referenced shows "Passed" for me?

[clalancette]

Hm, weird, I must have pasted the wrong URL. I'll update the description.

[dirk-thomas]

It's not entirely clear to me where that change is coming from

The new Q003 flake8 warnings seem to be related to the new release of flake8-quotes version 2.0.0: https://pypi.org/project/flake8-quotes/

Needs to be looked into.

It should be straight forward to address the reported cases.

[dirk-thomas]

I'll update the description.

The updated description still points to a page showing "Passed" for me?

[clalancette]

The updated description still points to a page showing "Passed" for me?

I have no idea; when I test the link locally the first time, it points the right place, and then after I post it, it points to a passed test. I'll try one more time, otherwise I'll just post a link to one of the build numbers.

[clalancette]

CI run here, as it requires all linked PRs to be successful:

• Linux
• Linux-aarch64
• macOS
• Windows

[dirk-thomas]

@clalancette Can this ticket be closed?

[clalancette]

Yes, good point, closing now.