Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install pyparsing #108

Merged
merged 1 commit into from
Nov 14, 2017
Merged

install pyparsing #108

merged 1 commit into from
Nov 14, 2017

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Nov 7, 2017
@dirk-thomas dirk-thomas self-assigned this Nov 7, 2017
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Just so I know, what's the reasoning behind installing both the package from the OS and installing it via pip?

@dirk-thomas
Copy link
Member Author

That is the way we do it for all other dependencies. On Ubuntu we want to use the Debian package. But all other platforms need pip.

@dirk-thomas dirk-thomas merged commit d06052d into master Nov 14, 2017
@dirk-thomas dirk-thomas deleted the rep149 branch November 14, 2017 23:38
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Nov 14, 2017
@dirk-thomas
Copy link
Member Author

Added pyparsing to the install instructions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants