Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reenable visualization_msgs #128

Merged
merged 1 commit into from
Mar 19, 2018
Merged

reenable visualization_msgs #128

merged 1 commit into from
Mar 19, 2018

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Mar 15, 2018

@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Mar 15, 2018
@wjwwood wjwwood self-assigned this Mar 15, 2018
mikaelarguedas
mikaelarguedas approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood
Copy link
Member Author

wjwwood commented Mar 15, 2018

I think this is working (just a different error now on ros2/rviz#229), but I'll wait until that is fully resolved and ready to merge.

@mikaelarguedas
Copy link
Member

Merging this as ros2/rviz#229 has been merged and ci fails without this change

@mikaelarguedas mikaelarguedas merged commit 6273280 into master Mar 19, 2018
@mikaelarguedas mikaelarguedas deleted the reenable_visualization_msgs branch March 19, 2018 05:23
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Mar 19, 2018
@wjwwood
Copy link
Member Author

wjwwood commented Mar 19, 2018

Dang, sorry I forgot to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@wjwwood wjwwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wjwwood @mikaelarguedas