Migrate marker display #229
Conversation
|
I'd say we wait for CI until the Pose-Display is sorted out (we'll need to rebase then anyway). |
- Fix QueueSizeProperty in MarkerDisplay - Fix MarkerArray subscription
Delete render_panel after visualization manager since the display cleanup in the visualization manager requires an existing render_panel
Martin-Idel-SI
force-pushed
the
feature/migrate_marker_display
branch
from
cee3ece
to
e30505e
Compare
|
CI after rebase on master:
It says it's going to not build but ignore |
|
I updated my repos file and everything, let's see what hapens:
|
|
I have no idea why the build ignores the common_interfaces repository. How can we fix this @wjwwood ? |
|
@Martin-Idel-SI we disable several of the message packages so to save time in the builds, I'll have to remove that one: |
|
Until that is merged, you can use |
|
Thanks! So I tried that, let's see where we're at:
|
| @@ -35,6 +35,7 @@ | |||
| <test_depend>ament_cmake_gmock</test_depend> | |||
| <test_depend>ament_cmake_lint_cmake</test_depend> | |||
| <test_depend>ament_cmake_uncrustify</test_depend> | |||
| <test_depend>rviz_rendering_tests</test_depend> | |||
There was a problem hiding this comment.
You'll need a <test_depend> or <depend> (if you use it in the source and not just the tests) on visualization_msgs.
There was a problem hiding this comment.
Clearly, yes. Thanks for noting that oversight on my part!
|
Next try:
|
|
Windows warning is a false positive, so CI looks good, let me do a code review real quick. |
wjwwood
added
enhancement
|
It would be good, in the future, to migrate some of the "acceptance tests" from rviz, like these: rviz/rviz/src/test/marker_test.cpp Line 1 in 8dfb0c0 |
Closes #100
This PR also adds a considerable amount of tests that are disabled for now.
It introduces convenience methods for scene graph introspection.