retain width and height after resize for master #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tonylitianyu <tonylitianyu@gmail.com>
jacobperron
reviewed
May 26, 2022
There was a problem hiding this comment.
Thanks for the pull request!
Could you also add test to this file for the resize methods?
Signed-off-by: tonylitianyu <tonylitianyu@gmail.com>
jacobperron
reviewed
May 31, 2022
Signed-off-by: tonylitianyu <tonylitianyu@gmail.com>
tonylitianyu
force-pushed
the
tonylitianyu/fix_point_cloud_size_master
branch
from
04b7adc
to
ec845d1
Compare
|
|
|
👨🌾 It seems this PR introduced some test regressions on the windows debug buildfarm jobs: I think in the resize function, instead of using |
|
new PR added for the type issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen a pull request for the master branch. The width and height were modified after this resize call. Now the width and height will be retained if they were set before. A new method is also provided to input the set width and height.
Signed-off-by: tonylitianyu tonylitianyu@gmail.com