Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed TODO #243

Merged
merged 2 commits into from Apr 15, 2024
Merged

Removed TODO #243

merged 2 commits into from Apr 15, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 12, 2024

There is a TODO that mentioned the adition of this message. Happy to remove the comment and the new message if this is not required anymore

There is already a service called GetMap.srv

@SteveMacenski, @tfoote ?

@ahcorde
Added GetMap.action to nav_msgs
0cedd3b 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 12, 2024
@ahcorde ahcorde requested a review from tfoote as a code owner April 12, 2024 14:37
@SteveMacenski
Copy link
Contributor

This seems like a weird action, I think a service is the most appropriate interface - but I suppose it doesn't hurt. Has anyone been requesting this?

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 12, 2024

Nope, I just saw the TODO

@SteveMacenski
Copy link
Contributor

SteveMacenski commented Apr 12, 2024 •
edited

My feedback is "lets just remove the TODO and see if anyone cares" since it doesn't seem that anyone has until now. But, hey, on the other hand, its not hurting anyone to add the new action.

@clalancette
Copy link
Contributor

My feedback is "lets just remove the TODO and see if anyone cares" since it doesn't seem that anyone has until now. But, hey, on the other hand, its not hurting anyone to add the new action.

I'd be more for removing the TODO. We shouldn't add things in that don't have users, in my opinion.

@tfoote
Copy link
Contributor

tfoote commented Apr 12, 2024

Thanks for finding the TODO and reviewing it. But I think that the GetMap action doesn't add a lot of value on top of the GetMap Service so as there's no demand we might as well not add it and keep things simpler.

tfoote
tfoote requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without feedback this doesn't add anything on top of the service. And we now have async service clients so that's not a benefit anymore either.

@ahcorde
Removed action
02d023d 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde changed the title Added GetMap.action to nav_msgs Removed TODO Apr 15, 2024
@ahcorde ahcorde requested a review from tfoote April 15, 2024 08:32
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 15, 2024

Thank you for the feedback, I just removed the TODO

tfoote
tfoote approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 15, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit c702bc2 into rolling Apr 15, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rolling/todo_get_map_action branch April 15, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahcorde @SteveMacenski @clalancette @tfoote