Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker.msg DELETE field conflicts with windows SDK 8.1 #44

Open
dejanpan opened this issue Oct 27, 2017 · 5 comments
Open

Marker.msg DELETE field conflicts with windows SDK 8.1 #44

dejanpan opened this issue Oct 27, 2017 · 5 comments

Comments

@dejanpan
Copy link

Bug report

It looks like I've found one more conflict with Windows SDK 8.1.
Windows SDK defines DELETE macro in winnt.h.
src\ros2\common_interfaces\visualization_msgs\msg\Marker.msg uses
uint8 DELETE=2

Required Info:

  • Operating System:
    Win 8.1
  • Installation type:
    source
  • Version or commit hash:
    beta3-release
  • DDS implementation:
    RTI Connext
  • Client library (if applicable):
    rmw_connext_cpp

Steps to reproduce issue

ament build

Expected behavior

compile sucesss

Actual behavior

compile fails

Additional information

@serge.nikulin

@serge-nikulin
Copy link

@dejanpan, I'm @serge-nikulin here.

@wjwwood
Copy link
Member

wjwwood commented Jun 15, 2018

@serge-nikulin
Copy link

Are you going to address it somehow?

@wjwwood
Copy link
Member

wjwwood commented Jun 15, 2018

Well in rviz we're using the recommended workaround which is to undef DELETE locally.

There's an effort underway to address the problem more generally, please ask there.

ros2/design#172
ros2/rosidl#118

@serge-nikulin
Copy link

nah, I'm good unless we support Windows formally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants