use add_compile_options instead of setting only cxx flags #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
added
in progress
|
Merging after getting offline approval from @wjwwood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now compile the C generated code with -Wpedantic (see ros2/ros2#567 (comment) for additional context).
I have a similar commits for all message packages, I am planning on getting the changes reviewed here and then push the other identical commits directly.
This does not supersede the work from ros2/ros2#567 that will eventually replace the way compile options are passed, but I figured I'd open this as I already had all the changes to confirm that ros2/rosidl_python#10 allowed us to compile with pedantic.
Below CI for all the
add_compile_optionsbranches.None:
Release:
Debug: