check that resolution is at least as big as burger #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
sloretz
reviewed
Jun 22, 2018
| if (x[b] < 0) { | ||
| x[b] = 0; | ||
| } else { | ||
| x[b] = width_i - burger_template.size().width; |
There was a problem hiding this comment.
Looks like x_inc[b] is unused?
There was a problem hiding this comment.
Correct, it just truncates the movement at the border. It had already been moved in line 133.
wjwwood
approved these changes
Jun 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254.
The first check ensures that the resolution is at least big enough to contain the burger template.
Additionally the initialization avoids a division by zero and the "bouncing" sacrifices "accuracy" over staying in bound in very constraint sizes.