Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demo_nodes_cpp] remove parameter node, all nodes take parameter by d… #265

Merged
merged 1 commit into from
Aug 3, 2018
Merged

[demo_nodes_cpp] remove parameter node, all nodes take parameter by d… #265

merged 1 commit into from
Aug 3, 2018

Conversation

mikaelarguedas
Copy link
Member

…efault now

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jun 29, 2018
@mikaelarguedas
Copy link
Member Author

Now that we have demos for both parameter events and parameter change callbacks I think this is ready for removal.

Rebased to resolve conflicts. Ready for review

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 3, 2018
@mikaelarguedas mikaelarguedas merged commit b9a8916 into master Aug 3, 2018
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Aug 3, 2018
@mikaelarguedas mikaelarguedas deleted the remove_parameter_node branch August 3, 2018 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@mikaelarguedas mikaelarguedas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikaelarguedas @wjwwood