Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup lifecycle demo #283

Merged
merged 1 commit into from
Nov 1, 2018
Merged

cleanup lifecycle demo #283

merged 1 commit into from
Nov 1, 2018

Conversation

Karsten1987
Copy link
Contributor

fixes ros2/rcl#309

The TRANSITION_SHUTDOWN is getting removed, because it's currently unused and thus misleading.
The demo scripts are cleanup/deleted correctly.

CI:
Build Status
Build Status
Build Status
Build Status

@Karsten1987 Karsten1987 added the in review Waiting for review (Kanban column) label Oct 30, 2018
@Karsten1987 Karsten1987 self-assigned this Oct 30, 2018
@dhood dhood added the in progress Actively being worked on (Kanban column) label Oct 30, 2018
@Karsten1987 Karsten1987 merged commit 2801180 into master Nov 1, 2018
@Karsten1987 Karsten1987 deleted the lifecycle_cleanup branch November 1, 2018 02:20
@Karsten1987 Karsten1987 removed in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) labels Nov 1, 2018
sloretz added a commit to ros2/ros2_documentation that referenced this pull request Dec 12, 2018
Change section from using lifecycle_service_client_py.py to use ros2 lifecycle
lifecycle_service_client_py.py was removed in ros2/demos#283
sloretz added a commit to ros2/ros2_documentation that referenced this pull request Dec 12, 2018
* Replace python script with ros2 lifecycle

Change section from using lifecycle_service_client_py.py to use ros2 lifecycle
lifecycle_service_client_py.py was removed in ros2/demos#283

* too -> tool

* remove trailing spaces
ferranm99 added a commit to ferranm99/ferran-ros that referenced this pull request May 20, 2022
* Replace python script with ros2 lifecycle

Change section from using lifecycle_service_client_py.py to use ros2 lifecycle
lifecycle_service_client_py.py was removed in ros2/demos#283

* too -> tool

* remove trailing spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lifecycle_service_client_py.py; it is deprecated and no longer works correctly
3 participants