Prevent frame going out of scope when converting RGB -> BGR #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
showimage
, when an image is encoded in RGB, it is converted into a BGR image. However, the converted frame is deallocated when thecv:Mat
referencing it,frame2
, goes out of scope, resulting in a segmentation fault when trying to show it.This PR fixes this by reusing the original
cv::Mat
incv::cvtColor
, which is safe, and stays in scope until the end of the function.