Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update constructor to const ref to NodeOptions #323

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Update constructor to const ref to NodeOptions #323

merged 1 commit into from
Apr 25, 2019

Conversation

mjcarroll
Copy link
Member

Addresses a comment from @dirk-thomas: #319 (review)

@mjcarroll
Update constructor to const ref to NodeOptions.
f0ddbd3 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll added the in progress Actively being worked on (Kanban column) label Apr 23, 2019
@mjcarroll
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll mjcarroll added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 23, 2019
@dirk-thomas dirk-thomas mentioned this pull request Apr 23, 2019
Merged
@mjcarroll
Copy link
Member Author

Not sure what these CI failures were, trying again:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll mjcarroll merged commit 1bf15a7 into master Apr 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the const_ref_constructor branch April 25, 2019 17:40
@mjcarroll mjcarroll removed the in review Waiting for review (Kanban column) label Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjcarroll @dirk-thomas